docs: Added english doc to how-to-migrate-from-1.x #4630
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4630 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 34 34
Lines 1112 1112
Branches 183 183
=========================================
Hits 1112 1112 Continue to review full report at Codecov.
|
docs/source/en/migration.md
Outdated
| - generator functions (delegation) | ||
|
|
||
| Use `async function` to replace the above functions, or use [app.toAsyncFunction] to wrap them if async function is not the case. |
There was a problem hiding this comment.
or use [app.toAsyncFunction] to wrap them if async function is not the case -> or use [app.toAsyncFunction] alternatively
There was a problem hiding this comment.
Updated, it's been changed to or use [app.toAsyncFunction] alternatively.
But it misses the 如果不能修改 part in ZH-CN version. TBD
docs/source/en/migration.md
Outdated
| In some cases, the interface provided by `Plugin developers` supports both generator and async, normally it's wrapped by co. | ||
|
|
||
| - In 2.x, we suggest to change to `async-first` in order to get a better performance and clearer error stacks. |
There was a problem hiding this comment.
- remove
to change to - remove
in order
There was a problem hiding this comment.
Updated.
I felt
we suggest to use
async-firstfor a better performance and clearer error stacks.
could be more natural. But I'm sure either way people'll get the point.
|
Did an extra checking, updated all the places accordingly, and also corrected a few undiscovered spelling mistakes. Thank you very very much for pointing out mistakes! 🙏 |
gemwuu
changed the title
docs: Added english doc to how-to-migrate-from-1.x (#4630) * Added english doc to how-to-migrate-from-1.x * Corrected typos and some other spelling errors, polished grammar accordingly
Checklist
npm testpassesAffected core subsystem(s)
No core subsystem is affected.
Description of change
Added English translation to migration.md under
enfolder.添加了
en文件夹下的 migration.md 英文版本。