Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: should log unfinished timing item #4968

Merged
merged 2 commits into from
Jun 17, 2022
Merged

feat: should log unfinished timing item #4968

merged 2 commits into from
Jun 17, 2022

Conversation

atian25
Copy link
Member

@atian25 atian25 commented Jun 17, 2022

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change
2022-06-17 10:50:12,770 ERROR 69291 application still doesn't ready after 1000 ms.
2022-06-17 10:50:12,770 ERROR 69291 unfinished timing item: {"name":"Application Start","start":1655434211766,"pid":69291,"index":1}
2022-06-17 10:50:12,771 ERROR 69291 unfinished timing item: {"name":"Did Load in app.js:didLoad","start":1655434211778,"pid":69291,"index":52}
2022-06-17 10:50:12,771 ERROR 69291 check run/application_timing_69291.json for more details.

@vercel
Copy link

vercel bot commented Jun 17, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
egg ✅ Ready (Inspect) Visit Preview Jun 17, 2022 at 3:34AM (UTC)

Copy link
Member

@mansonchor mansonchor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jun 17, 2022

Codecov Report

Merging #4968 (dd00035) into master (7f1689f) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #4968   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           34        34           
  Lines         1131      1136    +5     
  Branches       188       189    +1     
=========================================
+ Hits          1131      1136    +5     
Impacted Files Coverage Δ
lib/egg.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f1689f...dd00035. Read the comment docs.

@atian25 atian25 merged commit e0b93e0 into master Jun 17, 2022
@atian25 atian25 deleted the timeout branch June 17, 2022 03:53
@atian25 atian25 mentioned this pull request Jun 17, 2022
4 tasks
@fengmk2 fengmk2 added the core label Jun 17, 2022
iblogc pushed a commit to iblogc/egg that referenced this pull request Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants