Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dump config/timing when timeout #5069

Merged
merged 2 commits into from
Nov 28, 2022
Merged

fix: dump config/timing when timeout #5069

merged 2 commits into from
Nov 28, 2022

Conversation

killagu
Copy link
Contributor

@killagu killagu commented Nov 28, 2022

Checklist
  • npm test passes
  • [] tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@vercel
Copy link

vercel bot commented Nov 28, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
egg ❌ Failed (Inspect) Nov 28, 2022 at 3:51AM (UTC)

Copy link
Member

@atian25 atian25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我印象中 9 月的时候我也在支持这个,但好像还有个地方需要处理,就没提交,有点忘记了

@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Base: 99.85% // Head: 99.85% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (2396249) compared to base (ee2f061).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5069   +/-   ##
=======================================
  Coverage   99.85%   99.85%           
=======================================
  Files          35       35           
  Lines        3460     3462    +2     
  Branches      504      504           
=======================================
+ Hits         3455     3457    +2     
  Misses          5        5           
Impacted Files Coverage Δ
lib/egg.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fengmk2 fengmk2 merged commit c859506 into master Nov 28, 2022
@fengmk2 fengmk2 deleted the fix/timeout_dump branch November 28, 2022 05:30
@fengmk2
Copy link
Member

fengmk2 commented Nov 28, 2022

@killagu 你来发版本。

@killagu
Copy link
Contributor Author

killagu commented Nov 28, 2022

+ egg@3.5.1

iblogc pushed a commit to iblogc/egg that referenced this pull request Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants