Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve slogan #89

Merged
merged 2 commits into from
Sep 2, 2016
Merged

docs: improve slogan #89

merged 2 commits into from
Sep 2, 2016

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Sep 2, 2016

No description provided.

@fengmk2 fengmk2 added this to the v1.x milestone Sep 2, 2016
@mention-bot
Copy link

@fengmk2, thanks for your PR! By analyzing the annotation information on this pull request, we identified @popomore to be a potential reviewer

@fengmk2
Copy link
Member Author

fengmk2 commented Sep 2, 2016

image

image

@@ -5,14 +5,13 @@ menu:
release: Release

index:
title: "A web framework's framework for Node.js"
slogan: "Build Enterprise Web Application Simply"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这句去掉,下面的版面缺少了主次

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

下面那个想好再加吧,目前看来加了反而重复,不知道写什么。

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

下面这里主要是重要特性列表,后面再加上“ Reassuringly secure” 等特性,我觉得可以放两排的。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

其他的等之后加吧,没有 logo

@fengmk2
Copy link
Member Author

fengmk2 commented Sep 2, 2016

Current coverage is 95.64% (diff: 100%)

Merging #89 into master will not change coverage

@@             master        #89   diff @@
==========================================
  Files            33         33          
  Lines           804        804          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            769        769          
  Misses           35         35          
  Partials          0          0          

Powered by Codecov. Last update 0c53a5d...27025e5

@@ -1,6 +1,6 @@
![](https://cloud.githubusercontent.com/assets/985607/16881873/c1612cf8-4aee-11e6-9b51-e95412750930.png)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@popomore logo CDN 地址用那个?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

用 github 吧

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

等新图片上传

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

直接链 github 的 raw?

@popomore
Copy link
Member

popomore commented Sep 2, 2016

+1

@fengmk2 fengmk2 merged commit d36df0b into master Sep 2, 2016
@fengmk2 fengmk2 deleted the improve-slogan branch September 2, 2016 16:34
elrrrrrrr pushed a commit to elrrrrrrr/egg that referenced this pull request Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants