fix: maxSockets Infinity value may set to null sometimes #938
Conversation
Codecov Report
@@ Coverage Diff @@
## master #938 +/- ##
=======================================
Coverage ? 100%
=======================================
Files ? 28
Lines ? 670
Branches ? 0
=======================================
Hits ? 670
Misses ? 0
Partials ? 0
Continue to review full report at Codecov.
|
config/config.default.js
Outdated
| * @property {Number} maxFreeSockets - max free socket number of one host, default is 256. | ||
| * @property {Boolean} enableDNSCache - Enable DNS lookup from local cache or not, default is false. | ||
| */ | ||
| config.httpclient = { | ||
| keepAlive: true, | ||
| freeSocketKeepAliveTimeout: 4000, | ||
| timeout: 30000, | ||
| maxSockets: Infinity, | ||
| maxSockets: Number.MAX_VALUE, |
There was a problem hiding this comment.
目前还好的是 agentkeepalive 发现这个配置是 null 会默认设置为 Infinity https://github.com/node-modules/agentkeepalive/blob/master/lib/_http_agent.js#L63
config/config.default.js
Outdated
| * @property {Number} maxFreeSockets - max free socket number of one host, default is 256. | ||
| * @property {Boolean} enableDNSCache - Enable DNS lookup from local cache or not, default is false. | ||
| */ | ||
| config.httpclient = { | ||
| keepAlive: true, | ||
| freeSocketKeepAliveTimeout: 4000, | ||
| timeout: 30000, | ||
| maxSockets: Infinity, | ||
| maxSockets: Number.MAX_VALUE, |
config/config.default.js
Outdated
| * @property {Number} maxFreeSockets - max free socket number of one host, default is 256. | ||
| * @property {Boolean} enableDNSCache - Enable DNS lookup from local cache or not, default is false. | ||
| */ | ||
| config.httpclient = { | ||
| keepAlive: true, | ||
| freeSocketKeepAliveTimeout: 4000, | ||
| timeout: 30000, | ||
| maxSockets: Infinity, | ||
| maxSockets: utility.MAX_SAFE_INTEGER, |
There was a problem hiding this comment.
I think the more proper way is to use Number. MAX_SAFE_INTEGER instead of utility.MAX_SAFE_INTEGER. We only support node.js >= 6.0, so the Number.MAX_SAFE_INTEGER is always available.
There was a problem hiding this comment.
Yes, @coolme200 Please use Number.MAX_SAFE_INTEGER instead.
docs/source/zh-cn/core/httpclient.md
Outdated
| // 允许创建的最大 socket 数 | ||
| maxSockets: Infinity, | ||
| // 允许创建的最大 socket 数 https://github.com/node-modules/utility/blob/master/lib/number.js#L5 | ||
| maxSockets: utility.MAX_SAFE_INTEGER, |
|
@coolme200 我来改改手动合并。 |
Checklist
npm testpassesAffected core subsystem(s)
Description of change