👌 IMPROVE: [BREAKING] use eslint-plugin-jsdoc@39 to support Node.js 18 #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengmk2
commented
Jun 2, 2022
| @@ -18,7 +18,7 @@ | |||
| "@typescript-eslint/parser": "^5.4.0", | |||
| "eslint-plugin-eggache": "^1.0.0", | |||
| "eslint-plugin-import": "^2.25.3", | |||
| "eslint-plugin-jsdoc": "^37.0.3", | |||
| "eslint-plugin-jsdoc": "^39.3.0", | |||
There was a problem hiding this comment.
atian25
approved these changes
Jun 2, 2022
Only support Node.js >= 14 Remove strict rule
fengmk2
changed the title
|
@atian25 直接发大版本，只支持 node >= 14 |
|
去掉了 |
|
This pull request fixes 1 alert when merging 9aa6838 into c498d30 - view on LGTM.com fixed alerts:
|
4 tasks
|
This pull request fixes 1 alert when merging a8b7c6e into c498d30 - view on LGTM.com fixed alerts:
|
Codecov Report
@@ Coverage Diff @@
## master #64 +/- ##
=============================================
+ Coverage 0 100.00% +100.00%
=============================================
Files 0 29 +29
Lines 0 3285 +3285
Branches 0 94 +94
=============================================
+ Hits 0 3285 +3285
Continue to review full report at Codecov.
|
|
This pull request fixes 2 alerts when merging aad8fb0 into c498d30 - view on LGTM.com fixed alerts:
|
|
12.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only support Node.js >= 14
Remove strict rule