feat: add missing framework example #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 16, 2017
Closed
fengmk2
reviewed
Jan 16, 2017
| @@ -0,0 +1,17 @@ | |||
| 'use strict'; | |||
fengmk2
reviewed
Jan 16, 2017
| "description": "", | ||
| "dependencies": { | ||
| "egg": "^0.7.0", | ||
| "egg-view-nunjucks": "0.7.0" |
There was a problem hiding this comment.
egg-view-nunjucks 为何还不发布1.0？先发布 1.0 吧
There was a problem hiding this comment.
@popomore 上次说等他 review 后再发 1.0
There was a problem hiding this comment.
要不先发吧，没啥时候搞这个，现在看来没啥大问题，如果要重构再发 2.0
atian25
force-pushed
the
framework
branch
2 times, most recently
from
7c2d978
to
ad5a995
Compare
fengmk2
reviewed
Jan 16, 2017
| }, | ||
| "devDependencies": { | ||
| "autod": "^2.7.1", | ||
| "cheerio": "^0.22.0", |
There was a problem hiding this comment.
framework boilerplate 那边没删干净, 之前用来测试 view 输出的 html 的
fengmk2
reviewed
Jan 16, 2017
| ], | ||
| "author": "", | ||
| "license": "MIT", | ||
| "boilerplate": { |
There was a problem hiding this comment.
之前在 egg-init 里面做的 @_@ 记录是哪个版本的骨架... 要干掉么?
fengmk2
reviewed
Jan 16, 2017
|
|
||
| it('should GET /', () => { | ||
| return request(app.callback()) | ||
| .get('/') |
|
这个我来接手吧，我本地的还没提交，应该有两个库，app 如何使用 framework 也可以一起表现。 |
|
嗯, @popomore framework 那个文档感觉还需要优化下, 一开始就讲多进程, 有些看了觉得懵逼了. |
|
多进程前面讲了。。。 |
|
觉得这里应该先讲下, 应用如何使用框架, 框架如何减少团队成本, 然后才是框架如何定制. |
|
框架这篇就是如何定制了，如何使用前面已经说了。 |
|
|
|
前面都是使用的 egg |
|
rebase |
|
#9 里面已经涵盖了这个了, 可以直接 close |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
补上 framework.md 里面的示例链接