-
Notifications
You must be signed in to change notification settings - Fork 741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add missing framework example #8
Conversation
@@ -0,0 +1,17 @@ | |||
'use strict'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
文件名都小写+下划线吧
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
改了
"description": "", | ||
"dependencies": { | ||
"egg": "^0.7.0", | ||
"egg-view-nunjucks": "0.7.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
egg-view-nunjucks 为何还不发布1.0?先发布 1.0 吧
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@popomore 上次说等他 review 后再发 1.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个也去发 1.0.0 吧,然后依赖 ^1.0.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
要不先发吧,没啥时候搞这个,现在看来没啥大问题,如果要重构再发 2.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
发了
7c2d978
to
ad5a995
Compare
}, | ||
"devDependencies": { | ||
"autod": "^2.7.1", | ||
"cheerio": "^0.22.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个是干嘛的?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
framework boilerplate 那边没删干净, 之前用来测试 view 输出的 html 的
], | ||
"author": "", | ||
"license": "MIT", | ||
"boilerplate": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个不需要写吧。。。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
之前在 egg-init 里面做的 @_@ 记录是哪个版本的骨架... 要干掉么?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我知道啊,但是这个就是骨架,为何还要写?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
忘记删了~
|
||
it('should GET /', () => { | ||
return request(app.callback()) | ||
.get('/') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
加缩进2空格
这个我来接手吧,我本地的还没提交,应该有两个库,app 如何使用 framework 也可以一起表现。 |
嗯, @popomore framework 那个文档感觉还需要优化下, 一开始就讲多进程, 有些看了觉得懵逼了. |
多进程前面讲了。。。 |
觉得这里应该先讲下, 应用如何使用框架, 框架如何减少团队成本, 然后才是框架如何定制. |
框架这篇就是如何定制了,如何使用前面已经说了。 |
|
前面都是使用的 egg |
rebase |
#9 里面已经涵盖了这个了, 可以直接 close |
补上 framework.md 里面的示例链接