Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add argument to specify ofxclient config file #58

Merged
merged 2 commits into from
Sep 9, 2018

Conversation

501st-alpha1
Copy link
Contributor

I have separate ofxclient.ini files for my business vs. personal accounts, and I got tired of renaming them back and forth, so I've adding a command-line argument allowing me to specify which one I want to use. (This will also let me store the files elsewhere and have one less thing in $HOME.)

Let me know if you'd like me to add a test for this, or if you have any other suggestions.

@egh
Copy link
Owner

egh commented Sep 8, 2018

This looks good. My only hesitation would be that we might want to set up our own config file at some point, so maybe using --ofxconfig and -o rather than --config and -c? Would that work?

Might want to add ledger-autosync config file eventually.

egh#58 (comment)
@501st-alpha1
Copy link
Contributor Author

Yes that makes sense, and your suggestion sounds good. I've pushed another commit for that; let me know if you'd rather I squash them down into a single commit.

@egh
Copy link
Owner

egh commented Sep 9, 2018

Looks good to me! Thank you.

@egh egh merged commit 6923f26 into egh:master Sep 9, 2018
@501st-alpha1 501st-alpha1 deleted the feature/ofxclient-config-arg branch September 10, 2018 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants