Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match autosync payee #62

Merged
merged 6 commits into from
Mar 23, 2019
Merged

Match autosync payee #62

merged 6 commits into from
Mar 23, 2019

Conversation

501st-alpha1
Copy link
Contributor

This is my attempt at implementing payee matching for #25. I've implemented it for the plain Ledger interface, and haven't (yet) done so for the Python interface or HLedger. (I've been having some trouble getting the Python interface to work with ledger-autosync, and I haven't gotten around to installing HLedger yet.) I added non-fatal stub functions for those two so that it's backwards-compatible at least.

If you're okay with the stubs and want to merge this as is, feel free, otherwise I can try to implement those too.

@egh egh self-assigned this Feb 19, 2019
@egh
Copy link
Owner

egh commented Mar 17, 2019

Closing & re-opening to trigger travis build.

@egh egh closed this Mar 17, 2019
@egh egh reopened this Mar 17, 2019
@kotp
Copy link

kotp commented Mar 17, 2019

Closing and re-opening to trigger is not necessary, as you have write access to this repository. From the travis page targetted by "Details" for the job, there is a "Restart Job" button.

@egh
Copy link
Owner

egh commented Mar 17, 2019

@kotp Good to know, thanks!

`self.lgr` can be `None`, particularly during tests.
@501st-alpha1
Copy link
Contributor Author

501st-alpha1 commented Mar 23, 2019

@egh I've rebased this onto master, fixed an issue causing tests to fail, and also added a test for my new matching functionality.

@egh
Copy link
Owner

egh commented Mar 23, 2019

@501st-alpha1 Thank you!

@egh egh merged commit c2d5c2f into egh:master Mar 23, 2019
@501st-alpha1 501st-alpha1 deleted the match-autosync-payee branch March 27, 2019 04:32
@501st-alpha1 501st-alpha1 mentioned this pull request Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants