This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
align ol gt 10 #59
Merged
align ol gt 10 #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes an alignment issue for ordered list > 10 resolves #51
|
hmm does this work everywhere 😅 |
|
@egoist lmk where I should test. I built locally and checked two of the theme variants. It's an improvement over the current issue linked. 👍 |
|
what about >= 100? does this work? |
No. Nor would 1000 if 100 were added given current design. This pull addresses the immediate need in the issue and adds yarn. |
|
@egoist After some additional testing I fixed a bug where unordered lists were also receiving the style update for list sizes > 9. This is an incremental improvement. Could I get an emoji to rebase and merge into master? |
ghost
merged commit
|
Merged. Ready for release. |
|
@egoist time to release a patch from master, which includes these changes? |
|
Published, sorry I totally forgot about this 😅 |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes an alignment issue for ordered list > 10
resolves #51
@egoist