Skip to content
This repository has been archived by the owner on Dec 6, 2021. It is now read-only.

fix babel 7 babelrc validate failed #343

Closed
wants to merge 2 commits into from
Closed

fix babel 7 babelrc validate failed #343

wants to merge 2 commits into from

Conversation

dgeibi
Copy link

@dgeibi dgeibi commented Jan 8, 2018

babelrc validate failed in dev mode adding app/dev-client.es6 into entry
deepinscreenshot_select-area_20180108182033

babelrc validate failed in dev mode adding `app/dev-client.es6` into entry
@egoist
Copy link
Owner

egoist commented Jan 8, 2018

I guess we need to disable package's babelrc for all node_modules

i.e. pass the babelrc path we found

options.babel.babelrc = externalBabelConfig.options.babelrc !== false

@dgeibi
Copy link
Author

dgeibi commented Jan 8, 2018

Yes and I can only find the option in poi

i.e. as the error message said, it's ok for programmatic options

@dgeibi
Copy link
Author

dgeibi commented Jan 8, 2018

The babelrc option may have other value in the future, not touching it would be good.
babel/babel#6766

@egoist
Copy link
Owner

egoist commented Jan 8, 2018

Yes and I can only find the option in poi

what option?

@egoist
Copy link
Owner

egoist commented Jan 8, 2018

Now we completely disabled nested babelrc: dcfa562 since that's the source of many bugs 😅 However you can enable it by setting babel in Poi config:

module.exports = {
  // Use your own options for `babel-loader`
  // It could simply be an empty object
  babel: {}
}

@dgeibi
Copy link
Author

dgeibi commented Jan 8, 2018

@egoist Thank you for your nice work! 💯

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants