fix: add missing operators preventing the wait option to work (#7)

egoist · Dec 20, 2020 · f253235 · f253235
1 parent 6873117
commit f253235
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/src/index.ts b/src/index.ts
@@ -78,9 +78,9 @@ async function getHTML(browser: Browser, options: TakiOptions) {
   let result: Result | undefined
   if (options.manually) {
     result = await promise
-  } else if (options.wait === 'number') {
+  } else if (typeof options.wait === 'number') {
     await page.waitFor(options.wait)
-  } else if (options.wait === 'string') {
+  } else if (typeof options.wait === 'string') {
     await page.waitForSelector(options.wait)
   }
   content = result ? result.content : await page.content()

diff --git a/test/index.test.ts b/test/index.test.ts
@@ -21,7 +21,7 @@ test.before(async () => {
   server.listen(port)
 })
 
-test.after(async () => {
+test.after.always(async () => {
   server && server.close()
   await cleanup()
 })

diff --git a/test/server/wait-for-selector.html b/test/server/wait-for-selector.html
@@ -1,13 +1,13 @@
 <script>
 setTimeout(() => {
   document.write('foo')
-  window.snapshot && window.snapshot()
-}, 200)
+  window?.snapshot()
+})
 
 setTimeout(() => {
   const el = document.createElement('div')
   el.id = 'bar'
   el.textContent = 'bar'
   document.body.appendChild(el)
-}, 400)
+}, 2000)
 </script>