Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated role action as per mukta #409

Open
wants to merge 7 commits into
base: UAT
Choose a base branch
from
Open

Updated role action as per mukta #409

wants to merge 7 commits into from

Conversation

Vasanth26-egov
Copy link

No description provided.

@Vasanth26-egov Vasanth26-egov requested a review from a team as a code owner April 18, 2023 12:00
nipunarora-eGov
nipunarora-eGov requested changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@nipunarora-eGov nipunarora-eGov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes:
-> actionId 10 required for ESTIMATE_VIEWER role
-> actionId 77 required for ESTIMATE_VIEWER role

@Vasanth26-egov

@jagankumar-egov jagankumar-egov requested a review from a team as a code owner April 21, 2023 06:16
@jagankumar-egov
Copy link
Contributor

@Vasanth26-egov check these review point and update PR

@jagankumar-egov
Copy link
Contributor

@Vasanth26-egov @divya-egov Raise the Role action file seperately or check all module add only required actions
it has lot of other actions given to diff users

@jagankumar-egov
Copy link
Contributor

correct them , i had reviewed only Estimate creator and viewer
can u check all modules similarly and keep only required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nipunarora-eGov nipunarora-eGov nipunarora-eGov requested changes

@jagankumar-egov jagankumar-egov jagankumar-egov left review comments

@prachirane-eGov prachirane-eGov prachirane-eGov left review comments

@hariomsinha-eGov hariomsinha-eGov hariomsinha-eGov left review comments

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Vasanth26-egov @jagankumar-egov @nipunarora-eGov @prachirane-eGov @hariomsinha-eGov @divya-egov