fix receiving bug with try-catch, and add registeration api type classes. #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 12, 2019 08:46
* Add new RegisterUser function which is necessary in new api.
* It does not have try-catch and any error cause the receiver to permanently fail.
This was referenced Nov 12, 2019
x2bool
reviewed
Nov 15, 2019
| } | ||
| } | ||
| catch (Exception ex) |
There was a problem hiding this comment.
I don't think printing to Console from the library is a good solution. Maybe event would fit better in this case
|
Temporary fix is no longer needed. I've just updated this repo to 1.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since in the new version the registration process is changed, this commit fixes the bug temporary.
also in this pull request, the bug with receiving new updates caused by missing new API type is fixed.