Add search_with_limit
#197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwillsey
reviewed
Jul 27, 2022
src/rewrite.rs
Outdated
| @@ -128,7 +166,34 @@ where | |||
| { | |||
| /// Search one eclass, returning None if no matches can be found. | |||
| /// This should not return a SearchMatches with no substs. | |||
| fn search_eclass(&self, egraph: &EGraph<L, N>, eclass: Id) -> Option<SearchMatches<L>>; | |||
| /// | |||
| /// Implementation of [`Searcher`] should implement one of | |||
There was a problem hiding this comment.
Hmm, I appreciate the effort to not break the API, but this could be a little confusing because the "default" behavior is an infinite loop! I think we should require search_with_limit.
|
I've removed the default implementation of search_with_limit @mwillsey |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
BackoffSchedulerwill search each pattern, and if the match size is larger than the threshold, all the matches will be threw away and the rule will be banned. However, rules like AC will take an intractable amount of time and find ridiculously many matches, even when the threshold is small.This PR tries to add an interface for
search_with_limitandsearch_eclass_with_limit, while being compatible with the existing interface. With this PR, the e-matching machine will stop searching as soon as the number of matches hits the limit.