Prettyprinter #554
Merged
Prettyprinter #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oflatt
requested changes
May 9, 2024
clyben
force-pushed
the
prettyprint
branch
2 times, most recently
from
214c313
to
53a35fd
Compare
oflatt
requested changes
May 17, 2024
clyben
force-pushed
the
prettyprint
branch
3 times, most recently
from
804bd57
to
74639d9
Compare
yihozhang
reviewed
Jun 10, 2024
| } | ||
| } | ||
|
|
||
| pub fn map_expr_children<F>(self: &RcExpr, mut map_child: F) -> RcExpr |
There was a problem hiding this comment.
Maybe leaving a note saying that these functions may violate the invariant that RcExpr is interned (as mentioned in RcExpr's doc.
| let single_v7 = single(getat(2)); | ||
| let single_v8 = single(getat(3)); | ||
| let sub_v9 = sub(getat(2), | ||
| getat(1)); |
There was a problem hiding this comment.
Could you check if this getat(1) has a different context as single_v6. Also, could you document what is the current behavior of sharing for the pretty printer? My understanding is that it's not perfect (although pretty usable).
|
action items for this PR after a discussion:
|
yihozhang
approved these changes
Jun 19, 2024
yihozhang
dismissed
oflatt’s stale review
all the review comments should have been addressed now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a pretty printer which either output to rust macro or let-binded egglog.
Pretty printer could take a string of egglog output and parse it under current schema to RcExpr, or an RcExpr of program, output the rust macro or let-binded egglog.
Add runmode PrettyPrint and OptimizedPrettyPrint, which output the rust macro form of original program or optimized program.
To make rust macro look better copy it to rust file and "cargo fmt". Though you need to add ".with_arg_types(..)" and "add_ctx()" to make it runnable.