Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not validating use of special characters in domain correctly #57

Closed
SamBurns-awin opened this issue Apr 22, 2015 · 3 comments · Fixed by #59
Closed

Not validating use of special characters in domain correctly #57

SamBurns-awin opened this issue Apr 22, 2015 · 3 comments · Fixed by #59
Labels

Comments

@SamBurns-awin
Copy link

$validator = new \Egulias\EmailValidator\EmailValidator();
var_dump($validator->isValid('email.email@email.!"£$%^&*'));

Expected result: false
Actual result: true

@egulias
Copy link
Owner

egulias commented Apr 22, 2015

Hi @SamBurns-awin thanks for reporting.
From your example, only chars £ and " are invalid for a domain. I've added the tests, I'll release a fix asap.
The rest are "valid" in the broad definition given by RFC 5322 - 3.4.1

@egulias egulias added the bug label Apr 22, 2015
@SamBurns-awin
Copy link
Author

Thanks for your help @egulias :-)

@egulias
Copy link
Owner

egulias commented Apr 26, 2015

@SamBurns-awin char £ is UTF8 valid, thus initially valid for an email. I have to research some more through the RFC's to see if there's a restriction within the UTF8 chars that can be used.
If you happen to find this information, please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants