Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins: document example plugin #234

Closed
ehazlett opened this issue Jul 18, 2017 · 0 comments
Closed

Plugins: document example plugin #234

ehazlett opened this issue Jul 18, 2017 · 0 comments

Comments

@ehazlett
Copy link
Owner

We need docs for creating and using plugins. This should include an example.

ehazlett pushed a commit that referenced this issue Aug 16, 2019
* Makefile: Consolidate basic build arguments

Similar arguments appear in almost all builds, so keeping them together
reduces the chance of one build getting out of sync.

Signed-off-by: Euan Harris <euan.harris@docker.com>

* Dockerfile: Remove unused GOARCH and GOOS argument

These variables are used to select the appropriate Dockerfile, but are
not used within the Dockerfiles themselves.

Signed-off-by: Euan Harris <euan.harris@docker.com>

* Dockerfile: Parameterize build and base images

BUILD_CONTAINER is the Golang container used as the build environment
BASE_CONTAINER is the basis for the production containers

A few different versions of the Golang and Alpine containers were used
in various Dockerfiles.  For now we standardise on the 'average' versions
used, and will update to the latest versions in a future commit:

BUILD_CONTAINER: golang:1.8.3-alpine3.5
BASE_CONTAINER: alpine:3.7

Signed-off-by: Euan Harris <euan.harris@docker.com>

* vendor.conf: Remove unused packages and files

Signed-off-by: Euan Harris <euan.harris@docker.com>

* Dockerfile: Update build image to Go 1.11.4

The rttf test suite will not build unless CGO_ENABLED=0 is set

Signed-off-by: Euan Harris <euan.harris@docker.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant