Fix problems in Makefile

[yangdongsheng]

No description provided.

[yangdongsheng]

Fixes https://github.com/shipyard/shipyard/issues/596

[yangdongsheng]

@asdfsx @MironWong

[tombee]

LGTM

[ehazlett]

We need the = as this may not work in the future (this is a Go warning upon build).

[ehazlett]

To be clearer, it should not be changed from the previous.

[yangdongsheng]

But, we got an error in "make image" with =:

go version

go version go1.4.2 linux/amd64

Do you mean I need to upgrade my golang?

[ehazlett]

You shouldn't get an error and yes you should be using Go 1.5. Thanks!
On Dec 17, 2015 12:38 AM, "yangdongsheng" notifications@github.com wrote:

In Makefile
#705 (comment):

@@ -10,7 +10,7 @@ clean:
@rm -rf controller/controller

build:

• @cd controller && godep go build -a -tags "netgo static_build" -installsuffix netgo -ldflags "-w -X github.com/shipyard/shipyard/version.GitCommit=$(COMMIT)" .
• @cd controller && godep go build -a -tags "netgo static_build" -installsuffix netgo -ldflags "-w -X github.com/shipyard/shipyard/version.GitCommit $(COMMIT)" .

But, we got an error in "make image" with =:
go version

go version go1.4.2 linux/amd64

Do you mean I need to upgrade my golang?

—
Reply to this email directly or view it on GitHub
https://github.com/shipyard/shipyard/pull/705/files#r47871188.

[yangdongsheng]

So, can I say our Makefile is not compatible to Go version before 1.5? What about making it compatible?

[yangdongsheng]

@ehazlett and @tombee I updated it to make it compatible to different versions of golang, please take a look

[tombee]

@yangdongsheng is there a particular reason you want it to be compatible with 1.4?

IMO we should just leave it, and ensure we build with 1.5. Dockerfile.build uses golang:1.5.

[yangdongsheng]

@tombee I am using RHEL7, and I met this error in my building :(

[tombee]

Perhaps we can look at creating a script that automates the creations of the build image from Dockerfile.build, and then runs make inside a container.