Fix showSystem default value

src/bin/config/report.js

@@ -61,7 +61,7 @@ Default: false`,
   showSystem: {
     group: REPORT,
     describe: `Show hardware and software information.
-Default: true when the "system" configuration property is set, false otherwise`,
+Default: true when the result has a "system", false otherwise`,
   },
   showMetadata: {
     group: REPORT,

src/config/properties.js

@@ -1,8 +1,6 @@
 /* eslint-disable max-lines */
 import { cwd as getCwd } from 'process'
 
-import isPlainObj from 'is-plain-obj'
-
 import { normalizeLimit } from '../history/compare/normalize.js'
 import { normalizeDelta } from '../history/delta/normalize.js'
 import { getDefaultId, validateMerge } from '../history/merge/id.js'
@@ -22,7 +20,6 @@ import {
   checkJson,
 } from './check.js'
 import { normalizeConfigPath, normalizeConfigGlob } from './path.js'
-// eslint-disable-next-line import/max-dependencies
 import { recurseConfigSelectors } from './select/normalize.js'
 
 const METADATA_COMMANDS = new Set(['show', 'remove'])
@@ -207,9 +204,6 @@ export const CONFIG_PROPS = {
   },
   showSystem: {
     commands: 'report',
-    default(name, { config: { system } }) {
-      return isPlainObj(system) && Object.keys(system).length !== 0
-    },
     normalize(value, name) {
       checkBoolean(value, name)
     },

src/top/omit.js

@@ -40,13 +40,26 @@ export const omitMetadataFooterProps = function (result) {
 // This only impacts the footer, not the properties of the target result nor
 // history results.
 export const omitFooterProps = function (footer, showMetadata, showSystem) {
+  const showSystemA = addShowSystemDefault(footer.systems, showSystem)
   const footerA = maybeOmit(footer, showMetadata, METADATA_FOOTER_PROPS)
   const systems = footerA.systems.map((system) =>
-    omitFooterSystemProps(system, showMetadata, showSystem),
+    omitFooterSystemProps(system, showMetadata, showSystemA),
   )
   return { ...footerA, systems }
 }
 
+// By default, we show systems only if the result was created with the `system`
+// configuration property, i.e. there are some system dimensions
+const addShowSystemDefault = function (systems, showSystem) {
+  return showSystem === undefined
+    ? systems.some(hasSystemDimensions)
+    : showSystem
+}
+
+const hasSystemDimensions = function ({ dimensions }) {
+  return Object.keys(dimensions).length !== 0
+}
+
 const omitFooterSystemProps = function (system, showMetadata, showSystem) {
   const systemA = maybeOmit(system, showMetadata, METADATA_SYSTEM_PROPS)
   const systemB = maybeOmit(systemA, showSystem, MAIN_SYSTEM_PROPS)