Refactoring

ehmicky · Oct 3, 2021 · 96f34c4 · 96f34c4
1 parent eda30f3
commit 96f34c4
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/src/combination/ids.js b/src/combination/ids.js
@@ -41,11 +41,10 @@ export const hasSameCombinationIds = function (combinationA, combinationB) {
 }
 
 // Retrieve each dimension's id of a given combination
-// Does not follow `DIMENSIONS` array order.
+// Follows `DIMENSIONS` array order.
 export const getCombinationIds = function (combination) {
-  return Object.values(combination.dimensions).map(getCombinationId)
-}
-
-const getCombinationId = function ({ id }) {
-  return id
+  const dimensions = getCombDimensions(combination)
+  return dimensions.map(
+    (dimension) => combination.dimensions[dimension.propName].id,
+  )
 }