Rename

src/combination/ids.js

@@ -2,17 +2,17 @@ import { getCombDimensions } from './dimensions.js'
 
 // Check if two combinations have same identifiers for all dimensions
 export const hasSameCombinationIds = function (combinationA, combinationB) {
-  const combinationIdsA = getCombinationIds(combinationA)
-  const combinationIdsB = getCombinationIds(combinationB)
-  return combinationIdsA.every(
-    ({ id }, index) => combinationIdsB[index].id === id,
+  const dimensionsIdsA = getDimensionsIds(combinationA)
+  const dimensionsIdsB = getDimensionsIds(combinationB)
+  return dimensionsIdsA.every(
+    ({ id }, index) => dimensionsIdsB[index].id === id,
   )
 }
 
 // Retrieve all unique combinations identifiers.
 // For all combinations of a given result.
 export const getCombinationsIds = function (combinations) {
-  return combinations.flatMap(getCombinationIds).filter(isNotDuplicateId)
+  return combinations.flatMap(getDimensionsIds).filter(isNotDuplicateId)
 }
 
 // Remove duplicate ids with the same dimension, since this happens due to the
@@ -30,7 +30,7 @@ const isNotDuplicateId = function ({ dimension, id }, index, combinationIds) {
 
 // Retrieve each dimension's id of a given combination
 // Follows `DIMENSIONS` array order.
-export const getCombinationIds = function (combination) {
+export const getDimensionsIds = function (combination) {
   const dimensions = getCombDimensions(combination)
   return dimensions.map((dimension) => getCombinationId(combination, dimension))
 }

src/combination/name.js

@@ -1,7 +1,7 @@
 import { titleColor, noteColor } from '../report/utils/colors.js'
 
 import { omitCombNoDimensions } from './filter.js'
-import { getCombinationIds } from './ids.js'
+import { getDimensionsIds } from './ids.js'
 
 // Retrieve error message prefix showing a combination's dimension ids
 export const getCombinationPrefix = function (combination, noDimensions) {
@@ -21,14 +21,14 @@ export const getCombinationPrefix = function (combination, noDimensions) {
 //    and steps dimensions
 export const getCombinationNameColor = function (combination, noDimensions) {
   const combinationA = omitCombNoDimensions(combination, noDimensions)
-  return getCombinationIds(combinationA)
+  return getDimensionsIds(combinationA)
     .map(getNameColorPart)
     .join(NAME_SEPARATOR_COLOR)
 }
 
 export const getCombinationName = function (combination, noDimensions) {
   const combinationA = omitCombNoDimensions(combination, noDimensions)
-  return getCombinationIds(combinationA).map(getNamePart).join(NAME_SEPARATOR)
+  return getDimensionsIds(combinationA).map(getNamePart).join(NAME_SEPARATOR)
 }
 
 const getNameColorPart = function ({ dimension: { messageName }, id }) {

src/select/match.js

@@ -1,4 +1,4 @@
-import { getCombinationIds } from '../combination/ids.js'
+import { getDimensionsIds } from '../combination/ids.js'
 import { findIndexReverse } from '../utils/find.js'
 
 // Select combinations according to the `select|limit` configuration properties.
@@ -31,7 +31,7 @@ export const matchSelectors = function (combination, selectors) {
     return true
   }
 
-  const combinationIds = getCombinationIds(combination).map(getCombinationId)
+  const combinationIds = getDimensionsIds(combination).map(getCombinationId)
   const index = findIndexReverse(selectors, (selector) =>
     matchIds(combinationIds, selector),
   )