Refactoring

ehmicky · Dec 19, 2021 · bfbd63f · bfbd63f
1 parent 33b3027
commit bfbd63f
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/src/combination/ids/namespace.js b/src/combination/ids/namespace.js
@@ -62,10 +62,7 @@ const namespaceDimensionId = function (
 ) {
   const similarDimensionId = addDimensionId(dimensionsIds, combDimensionId)
 
-  if (
-    similarDimensionId === undefined ||
-    isSameDimension(combDimensionId, similarDimensionId)
-  ) {
+  if (!shouldNamespace(similarDimensionId, combDimensionId)) {
     return combination
   }
 
@@ -75,6 +72,13 @@ const namespaceDimensionId = function (
   return combinationA
 }
 
+const shouldNamespace = function (similarDimensionId, combDimensionId) {
+  return (
+    similarDimensionId !== undefined &&
+    !isSameDimension(combDimensionId, similarDimensionId)
+  )
+}
+
 const addNamespace = function (
   combDimensionId,
   dimensionsIds,