Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make base image configurable #3

Merged
merged 2 commits into from
May 9, 2018
Merged

Conversation

phlax
Copy link
Contributor

@phlax phlax commented May 9, 2018

this PR allows the base image to be set with a BUILD_FROM env var

it also defaults to the more lightweight stretch-slim, and makes package install non-interactive

@phlax phlax force-pushed the configurable-base-image branch from 8214782 to 60c8b13 Compare May 9, 2018 10:17
@ehough
Copy link
Owner

ehough commented May 9, 2018

Love it. Thanks for your contribution!

One nitpicky issue before I merge; it seems that ENV DEBIAN_FRONTEND=noninteractive in the Dockerfile is not considered best practice. If you read through that issue, the consensus is to either omit the line entirely or instead use:

ARG DEBIAN_FRONTEND=noninteractive

so that the variable doesn't persist into the running container. Thoughts? I'm happy to make this tweak after merging, but wanted to give you an opportunity to opine and/or add another commit.

Thanks again!

@phlax
Copy link
Contributor Author

phlax commented May 9, 2018

hi @ehough - using an ARG seems like a good compromise - its needed for the slim image as it has no readline support

feel free to hack/squash/merge as you see fit

@ehough ehough merged commit 60c8b13 into ehough:master May 9, 2018
@ehough
Copy link
Owner

ehough commented May 9, 2018

@phlax thanks again, and please feel free to send along any other suggestions or improvements.

@phlax
Copy link
Contributor Author

phlax commented May 10, 2018

@ehough ive used your build in a travis test:

https://travis-ci.org/phlax/nfs-client/builds/377456887

for an nfs-client im working on:

https://github.com/phlax/nfs-client

it actually uses my build - but only as the image is smaller

if its helpful i can PR to add a travis test using my client, optionally that pushes master to dockerhub on successful build

@ehough
Copy link
Owner

ehough commented May 11, 2018

Very slick! That's a great idea - I would love to use your client for CI purposes. Please feel free to send along a PR and we'll get it merged. Once that foundation is in place, I can think of a bunch of scenarios that would be good to test. i.e. NFS v3, NFS v4, Kerberos, UDP/TCP, etc.

Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants