Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the kernel module assertion to consider builtin modules #4

Merged
merged 1 commit into from
Jun 7, 2018

Conversation

dalazx
Copy link
Contributor

@dalazx dalazx commented Jun 6, 2018

This PR addresses the issue when the nfs and nfsd modules are built into kernel. the docker-machine/minikube VM images have them builtin.
lsmod lists only dynamically loaded ones.
cat /lib/modules/$(uname -r)/modules.builtin consists of a list of builtin modules, but it is not accessible from a container. instead, /sys/module/* directories are used as indicators of presence of certain builtin modules.

@ehough ehough merged commit b24dd37 into ehough:develop Jun 7, 2018
ehough added a commit that referenced this pull request Jun 7, 2018
@ehough
Copy link
Owner

ehough commented Jun 7, 2018

This is great, thank you!

Seems to me like maybe we could ditch lsmod entirely, as the existence of a directory at /sys/module/* seems to be a good indicator for both dynamic and static modules. Thoughts?

In the meantime, I've built a new latest on Docker Hub, so you should be able to pull it down and use it now.

@dalazx dalazx mentioned this pull request Jun 7, 2018
@dalazx
Copy link
Contributor Author

dalazx commented Jun 7, 2018

@ehough thank you!
I think the current condition addresses the issue and does not really add significant overhead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants