add prop-shop and example propType with description #421
Conversation
|
@ehowey urg! is that build error me or something else, i haven't touched the writer starter. |
|
Unless you set up sanity and all your env variables that build error Is probably you. If you look in the docs there is a guide for setting it up on my website. The writer theme won’t work out of the box because it needs the content from Sanity.
…On Feb 13, 2020, 4:12 AM -0700, Paul Scanlon ***@***.***>, wrote:
@ehowey urg! is that build error me or something else, i haven't touched the writer starter.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
Oh I see - the test failed. That is odd. It was running fine last night and the env variables are set up through GH actions...I gotta think about that...I wont be able to look into that more until tonight. Sorry Paul! That might not be you. |
|
I just opened another PR myself to see if it passes for me. It shouldnt matter who opened the PR though because the ENV variables are set through a GH secret and not an ENV file. This is a bit odd, sorry Paul. May take some more trouble shooting for me tonight when I am home from work. If the tests pass on the PR I just opened that will tell us something. |
|
Okay my PR just failed tests for the same reason. I gotta look into that maybe it is something on SANITYs end of things because the tests were all passing and working fine yesterday. Safe to say that isnt you. |
|
@ehowey blimey! i missed a lot of action while i was asleep. Lemme know if i can help! |
|
First of all - NICE WORK - it looks so awesome Paul. I am excited to use it and learn more about propTypes. To be honest I haven't really done a good job cough have not cough done propTypes in this project yet. With regards to the failing test for the writer theme, I am actually kinda confused. I relooked at why my tests on the other PR failed, it failed because of another error, it is an experimental branch I am playing around with. When I made a fresh PR off the master it builds fine and passes all the test. Which is making me scratch my head. Your PR also builds and works fine in my local development environment. No errors or problems...strange one...all the tests run and pass. I'll do a little more digging but it isn't anything you should worry about with prop-shop. Something funky is happening with the tests and GH. I wonder if it is something about how GH secrets are stored or accessible by third parties? It seems to be working fine for PRs from me, but maybe because I am the owner I can access the GH secrets?? |
|
https://developer.github.com/v3/actions/secrets/ So it looks like it is failing because an issue with GH secrets. "Authenticated users must have collaborator access to a repository to create, update, or read secrets." So when it tries to build the writer theme it is failing because you don't have access to the secrets necessary to pull data from the API. I will just make the database public and remove the need for secrets, I think I can do that through SANITY. |
|
Gonna close this out Paul! |
Hey @ehowey Here's that alpha of "Project Prop" i promised.
As you can see, it's now called PropShop 😊
If you spin up
develop:corethen navigate tohttp://localhost:8000/prop-shop/you should see all the PropType information for.jsfiles in your core theme.... there wasn't actually any propTypes added so i've popped one in otherwise the plugin errors.