-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the JWST aperture. #139
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses Matplotlib Paths to evaluate. Uses a bounding box for performance.
ehpor
force-pushed
the
feature/jwst_aperture
branch
from
August 5, 2022 22:40
8459c7d
to
af0d4a0
Compare
Codecov Report
@@ Coverage Diff @@
## master #139 +/- ##
==========================================
+ Coverage 80.45% 80.65% +0.19%
==========================================
Files 94 94
Lines 6785 6854 +69
==========================================
+ Hits 5459 5528 +69
Misses 1326 1326
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
syhaffert
reviewed
Aug 5, 2022
syhaffert
reviewed
Aug 5, 2022
syhaffert
requested changes
Aug 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have two comments for this PR.
syhaffert
approved these changes
Aug 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aperture is based on the one from WebbPSF. (FYI @mperrin)
This PR adds:
This PR depends on #136, so test failures are expected until that PR is merged and this PR is rebased.
Reference apertures for test (with and without struts):