Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDR-647 remove old participations on event_context update #1016

Merged
merged 7 commits into from
Dec 14, 2022

Conversation

vmueller-vg
Copy link
Contributor

@vmueller-vg vmueller-vg commented Dec 8, 2022

Changes

  • replace old participations on updating an event_context for correct representation in all composition versions

Related issue

Additional information and checks

  • Pull request linked in changelog

@vmueller-vg vmueller-vg marked this pull request as draft December 8, 2022 11:28
@vmueller-vg vmueller-vg force-pushed the feature/CDR-647_fix-participations branch 4 times, most recently from 1c236db to f516067 Compare December 12, 2022 13:29
@vmueller-vg vmueller-vg force-pushed the feature/CDR-647_fix-participations branch from f516067 to 29034ee Compare December 12, 2022 13:57
@vmueller-vg vmueller-vg marked this pull request as ready for review December 12, 2022 13:58
@vmueller-vg vmueller-vg marked this pull request as draft December 12, 2022 19:05
@vmueller-vg vmueller-vg marked this pull request as ready for review December 12, 2022 19:23
@sonarcloud
Copy link

sonarcloud bot commented Dec 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

61.0% 61.0% Coverage
0.0% 0.0% Duplication

// retrieve performer
PartyProxy performer = new PersistedPartyProxy(domainAccess).retrieve(historyRecord.getPerformer());

DvInterval<DvDateTime> startTime = null;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why has this been inlined?
Maybe two methods ::convertDvIntervalDvDateTimeFromRecord for ParticipationRecord and
ParticipationHistoryRecord.

@HolgerReiseVSys HolgerReiseVSys merged commit 2ceb5e8 into develop Dec 14, 2022
@HolgerReiseVSys HolgerReiseVSys deleted the feature/CDR-647_fix-participations branch December 14, 2022 10:00
jbellmann added a commit to NUM-Forschungsdatenplattform/ehrbase that referenced this pull request Jan 20, 2023
* chore(docs): github project documentation and guidelines

* chore(docs): PR template

* chore(docs): added mailing contacts and security disclosure policy

* Updated README about integration tests

* CDR-647 remove old participations on event_context update (ehrbase#1016)

* fix: removing non required trigger on audit details table (ehrbase#1020)

* empty validation on language

* Update CHANGELOG.md

* unwrap if match additional double quotes (ehrbase#1022)

* unwrap if match with additional double quotes

* Update CHANGELOG.md

* validate if party already exist for exr

* Revert "validate if party already exist for exr"

This reverts commit 8341496.

* validate if party already exist for exr

* Update CHANGELOG.md

* fix when subject is empty

* Deleted docker-example folder

* Remove duplicates from README

* Update maven version for circle ci

* refactoring

* refactoring

* refactoring

* add message details

* add management endpoints access control

* add management base path from the properties file

* add management endpoints access control

* add import

* change error description

* Feature/cdr 595 (ehrbase#1025)

* Added Security/Authorization Support

* Applied Spotless

* Fixed CDR-655

* apply spotless

Co-authored-by: MBA <michael.baumann@vitagroup.ag>
Co-authored-by: stefan.spiska <stefan.spiska@vitagroup.ag>

* update CHANGELOG.md

* update CHANGELOG.md

* update CHANGELOG.md

* update CHANGELOG.md

* add comments

* remove comments

* remove unused class

* try to fix

* Revert "try to fix"

This reverts commit d94944c.

* Impl. Tenant readyness for plugins

* Applied Spotless

* Applied change requests

* Merge conflict

* Removed duplicate code

* Added change log

* Applied spotless

* Fix PR template

* error name change

* Remove test-defect as robot tests are in a dedicated repository

* Feature/cdr 614 (ehrbase#1035)

* feat: change executor for SECURITY_TESTS Robot suite - add Mockserver

* feat: test cdr-614

* feat: test cdr-614

* fix: add machine to docker-mock-server executor

* fix: add docker-mock-server executor to SECURITY-test

* fix: configurations fix for circle-ci pipeline

* fix: add Docker image to docker-mock-server

* fix: test pipeline

* fix: test pipeline with new executor on SECURITY-test

* fix: test pipeline with new executor on SECURITY-test

* fix: add step to install docker-compose

* fix: add sudo to mv folder contents when using docker-compose

* fix: adjust to Debian commands

* fix: add setup_remote_docker

* fix: remove Build test image step

* fix: install and start mockserver from docker image

* fix: test pipeline for CDR-614

* fix: test pipeline for CDR-614 with port 1080 on mockserver

* fix: test pipeline execution for SECURITY-tests

* fix: test pipeline execution for SECURITY-tests with fixed positional args

* fix: test mockserver with port 1080

* fix: test mockserver with port 1080

* fix: test pipeline execution with abac.enabled=true

* fix: test pipeline execution with positional args fix

* fix np on checkAbacPre when missed ehr id (ehrbase#1031)

* fix np on checkAbacPre when missed ehr id

* Feature/cdr 661 valid template returns 400 (ehrbase#1029)

* fix XML as fallback for empty header
* not acceptable when json

* add semver validation (ehrbase#1032)

* Bugfix/cdr 654 storing queries detailed error version (ehrbase#1039)

* Sync/feature/cdr 525 stored query text plain request (ehrbase#1021)

* Added read the docs badge

Co-authored-by: Maxim Ni <maxim.ni@vitasystems.dev>
Co-authored-by: Alex Vidrean <alex.vidrean@gmail.com>
Co-authored-by: vmueller-vg <100680528+vmueller-vg@users.noreply.github.com>
Co-authored-by: Robert Hunter <50167182+robert-hunter-nes@users.noreply.github.com>
Co-authored-by: Dmitry Tulba <tulbad1@gmail.com>
Co-authored-by: Alex <alexandru.vidrean.ext@vitagroup.ag>
Co-authored-by: Michael Baumann <micha.bau@gmx.de>
Co-authored-by: MBA <michael.baumann@vitagroup.ag>
Co-authored-by: stefan.spiska <stefan.spiska@vitagroup.ag>
Co-authored-by: vladislavploaia <100927963+vladislavploaia@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants