Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update pfRICH gdml to v03 #397

Closed
wants to merge 9 commits into from
Closed

feat: update pfRICH gdml to v03 #397

wants to merge 9 commits into from

Conversation

c-dilks
Copy link
Member

@c-dilks c-dilks commented Mar 11, 2023

Briefly, what does this PR introduce?

Update version v03 of the pfRICH from @alexander-kiselev

TODO

  • verify there is no overlap with the tracker support (or anything else)

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

no

Does this PR change default behavior?

no

@github-actions github-actions bot added topic: backward Negative-rapidity detectors (electron-going side) topic: PID Particle identification labels Mar 11, 2023
@github-actions github-actions bot added the topic: infrastructure Regarding build system, CI, CD label Mar 11, 2023
@c-dilks
Copy link
Member Author

c-dilks commented Mar 20, 2023

There is still a slight overlap with the barrel TOF. If I push the pfRICH toward -z, then it bumps into the ECal, so the pfRICH z-length needs to be reduced.

The menagerie says the max length can be 54.1 cm.

@alexander-kiselev
Copy link

alexander-kiselev commented Mar 23, 2023 via email

@c-dilks
Copy link
Member Author

c-dilks commented Mar 23, 2023

Anyway, pfRICH container volume is 541.5mm . Are you saying we should fit into 541mm, and then everything will be fine?

That's what I thought, and yes 541.0 mm should be good. Could you make this change and email me the new GDML, or just push it to this branch?

It can perfectly be that other subsystems (as described in dd4hep) do not really follow the details of their respective CAD models.

This is a general problem resulting from 3 (4?) different places with geometry specification, each claiming to be "official." We need open access to everything, including the CAD models, improved communcation, and automation to ensure consistency. The production of GDML files on the DD4hep side is fully automated and the latest ones are always available at https://eic.github.io/epic/artifacts

@wdconinc
Copy link
Contributor

Merged main into branch, fixed conflicts due to removal of no_hcal geometries.

@c-dilks
Copy link
Member Author

c-dilks commented Sep 1, 2023

Closing in favor of #512.

@c-dilks c-dilks closed this Sep 1, 2023
@c-dilks c-dilks deleted the update-pfrich-gdml branch September 1, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: backward Negative-rapidity detectors (electron-going side) topic: infrastructure Regarding build system, CI, CD topic: PID Particle identification
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants