-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update pfRICH gdml
to v03
#397
Conversation
There is still a slight overlap with the barrel TOF. If I push the pfRICH toward -z, then it bumps into the ECal, so the pfRICH z-length needs to be reduced. The menagerie says the max length can be 54.1 cm. |
Hi Chris,
sorry, missed this one. Menagerie is a rather poor reference, as we realized with Alex. It can perfectly be that other subsystems (as described in dd4hep) do not really follow the details of their respective CAD models. Anyway, pfRICH container volume is 541.5mm . Are you saying we should fit into 541mm, and then everything will be fine? Sure we can do this. But I was wondering, how realistic are then the clearance settings along the beam line direction? Alex, can you probably also comment on this, at least on the CAD model side (pfRICH clearance to tracker and EmCal)?
Cheers,
Alexander.
…________________________________
From: Christopher Dilks ***@***.***>
Sent: Monday, March 20, 2023 9:40 AM
To: eic/epic ***@***.***>
Cc: Kiselev, Alexander ***@***.***>; Mention ***@***.***>
Subject: Re: [eic/epic] feat: update pfRICH `gdml` to `v03` (PR #397)
There is still a slight overlap with the barrel TOF. If I push the pfRICH toward -z, then it bumps into the ECal, so the pfRICH z-length needs to be reduced.
The menagerie says the max length can be 54.1 cm.
—
Reply to this email directly, view it on GitHub<#397 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ANV7FIIIF6GXIQQ2GO5W5ATW5BM6RANCNFSM6AAAAAAVXIY7BM>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
That's what I thought, and yes 541.0 mm should be good. Could you make this change and email me the new GDML, or just push it to this branch?
This is a general problem resulting from 3 (4?) different places with geometry specification, each claiming to be "official." We need open access to everything, including the CAD models, improved communcation, and automation to ensure consistency. The production of GDML files on the DD4hep side is fully automated and the latest ones are always available at https://eic.github.io/epic/artifacts |
Merged main into branch, fixed conflicts due to removal of |
for more information, see https://pre-commit.ci
Closing in favor of #512. |
Briefly, what does this PR introduce?
Update version
v03
of the pfRICH from @alexander-kiselevTODO
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
no
Does this PR change default behavior?
no