Updated pfRICH gdml #512
Closed
Updated pfRICH gdml #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
topic: backward
kkauder
requested review from
wdconinc,
rahmans1,
T-Britton and
alexander-kiselev
wdconinc
reviewed
Sep 1, 2023
Comment on lines
+13
to
+29
| # tof_barrel: | ||
| # tof_endcap: | ||
| pid: | ||
| dirc: | ||
| pfrich_gdml: | ||
| # drich: | ||
| ecal: | ||
| # forward_homogeneous: | ||
| # forward_insert_homogeneous: | ||
| # barrel_interlayers: | ||
| backward_PbWO4: | ||
| solenoid: | ||
| hcal: | ||
| # lfhcal_with_space_for_insert: | ||
| # forward_insert: | ||
| # barrel_gdml: | ||
| backward: |
|
We have decided to use DD4hep for the geometry description not GDML. What is the plan to provide the geometry for the pfRICH accordingly? |
|
Hi Markus,
our painful experience with porting a similar stack to dd4hep "all at once" in ATHENA times made me thinking that it may be easier to split the task into two or three: (1) port the simulation and reconstruction using GDML and optical description .root file which are guaranteed to be in sync with each other, (2) once this works, describe optical part in dd4hep on top of a dead material GDML file, (3) port the dead material. Perhaps #2,3 can be done at once.
Cheers,
Alexander.
…________________________________
From: Markus Diefenthaler ***@***.***>
Sent: Friday, September 1, 2023 5:29 PM
To: eic/epic ***@***.***>
Cc: Kiselev, Alexander ***@***.***>; Review requested ***@***.***>
Subject: Re: [eic/epic] Updated pfRICH gdml (PR #512)
We have decided to use DD4hep for the geometry description not GDML. What is the plan to provide the geometry for the pfRICH accordingly?
—
Reply to this email directly, view it on GitHub<#512 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ANV7FIJ2MXA5BXDXU42E2LTXYJHVHANCNFSM6AAAAAA4IACJNM>.
You are receiving this because your review was requested.Message ID: ***@***.***>
|
|
@kkauder We are tagging a new release in preparation for the February campaign. Is this PR ready? |
|
Closing in favor of #664 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
Update the gdml description to v06 with new geometry. Tested for overlaps. Added craterlake-based configurations for this version.
This description, via gdml, should be the new default going forward.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
It is set up to fit within craterlake. Other configurations using the same gdml could potentially cause overlaps
Does this PR change default behavior?
Only for older configurations, and only those that use the gdml version of the pfRICH.