Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add html format support in Detector Parameter Comparison #582

Merged
merged 3 commits into from
Oct 19, 2023

Conversation

Chao1009
Copy link
Contributor

@Chao1009 Chao1009 commented Oct 19, 2023

Briefly, what does this PR introduce?

A new table with some typo fixes is at https://eic.jlab.org/Geometry/Detector/Detector-20231013155913.html, but without csv format.
Since we expect more of the fixes to come, adding a support for extracting html table would be easier to update the comparison reports.
Related to issue #567

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No

Does this PR change default behavior?

No

@Chao1009 Chao1009 self-assigned this Oct 19, 2023
@github-actions github-actions bot added the topic: infrastructure Regarding build system, CI, CD label Oct 19, 2023
@Chao1009 Chao1009 marked this pull request as ready for review October 19, 2023 04:02
@Chao1009
Copy link
Contributor Author

Chao1009 commented Oct 19, 2023

Comparison with
./bin/compare_detector_parameter_table https://eic.jlab.org/Geometry/Detector/Detector-20231013155913.html https://eic.jlab.org/Geometry/Detector/Detector-20230929162408.html -v --template templates/DetectorParameterTable.csv.jinja2

Note here det is the 1013 parameters (after fixes), and sim is the 0927 parameters, only showing the 5 mismatched values.

CENTRAL DETECTOR, Inner Tracker (Si Barrel), : 
                          det   sim template_var        stat
Outer Radius (cm)        42.5  45.5        Empty  Mismatched

CENTRAL DETECTOR, Inner Tracker (Si Barrel), Si Layer 3: 
                          det   sim                        template_var        stat
Inner Radius (cm)        12.0   8.0         {{VertexBarrelLayer3_rmin}}  Mismatched
Outer Radius (cm)        12.5   8.5         {{VertexBarrelLayer3_rmax}}  Mismatched
 
CENTRAL DETECTOR, Inner Tracker (Si Barrel), Si Layer 5: 
                          det   sim                  template_var        stat
Inner Radius (cm)        42.0  45.0       {{SiBarrelLayer2_rmin}}  Mismatched
Outer Radius (cm)        42.5  45.5       {{SiBarrelLayer2_rmax}}  Mismatched

Copy link
Contributor

@wdconinc wdconinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I still think that we should ask the Tanja and Walt to upload csv files. The html is likely created from data stored in yet another format, so the html is not a stable interface. It only happens to work. CSV should be stable.

@Chao1009 Chao1009 added this pull request to the merge queue Oct 19, 2023
Merged via the queue into main with commit a10c91e Oct 19, 2023
85 checks passed
@Chao1009 Chao1009 deleted the update-det-para-comparison branch October 19, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: geometry topic: infrastructure Regarding build system, CI, CD
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants