-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detector Parameters Update: Inner Trackers #567
Comments
Chao1009
added this to the Update Compact Files According to 2023.09 Detector Parameters milestone
Oct 12, 2023
Chao1009
changed the title
Detector Parameters Update:
Detector Parameters Update: Inner Trackers
Oct 12, 2023
7 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Oct 19, 2023
### Briefly, what does this PR introduce? A new table with some typo fixes is at https://eic.jlab.org/Geometry/Detector/Detector-20231013155913.html, but without csv format. Since we expect more of the fixes to come, adding a support for extracting html table would be easier to update the comparison reports. Related to issue #567 ### What kind of change does this PR introduce? - [ ] Bug fix (issue #__) - [ ] New feature (issue #__) - [ ] Documentation update - [x] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [ ] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? No ### Does this PR change default behavior? No --------- Co-authored-by: Chao Peng <cpeng@anl.gov>
Hi @ShujieL , any progress in updating these parameters? |
github-merge-queue bot
pushed a commit
that referenced
this issue
Nov 15, 2023
### Briefly, what does this PR introduce? Updates MPGD disks to match detector parameter table ### What kind of change does this PR introduce? - [x] Bug fix (issue #567 ) - [ ] New feature (issue #__) - [] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [ x] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? There should be no breaking changes ### Does this PR change default behavior? No
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
EDIT: update comparison with the 2023/10/13 table
https://eic.jlab.org/Geometry/Detector/Detector-20231013155913.html
A series of smaller issues from #552
det
: new value from 2023/09/27 parameter tablesim
: current simulation value as of 2023/10/11template_var
: from which we extract the sim value in compact files.Empty
means we do not know.stat
:Correct
,Missing
, orMismatched
Please implement the new detector parameters, and try to fill in the
template_var
for theMissing
ones if you think it's important for future simulation/design comparison.The text was updated successfully, but these errors were encountered: