Update with new parameter table - to solve issue #573 #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chao1009
added this to the Update Compact Files According to 2023.09 Detector Parameters milestone
Chao1009
approved these changes
Nov 7, 2023
|
What is the problem here? Can we merge it? I don't see these failing checks being related to the backward HCal or update we did. |
Updated sizes with new values from 2023/09/27 parameter table
Updating nHCal inner radius to avoid overlaps
Update inner nHCal radius to avoid overlaps
sly2j
force-pushed
the
573-detector-parameters-update-lepton-endcap-hcal
branch
from
09d279c
to
9e7950a
Compare
Chao1009
deleted the
573-detector-parameters-update-lepton-endcap-hcal
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated sizes with new values from 2023/09/27 parameter table
Briefly, what does this PR introduce?
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
Need to verify if it doesn't overlap with any beampipes
Does this PR change default behavior?