Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detector Parameters Update: Lepton Endcap HCal #573

Closed
Chao1009 opened this issue Oct 12, 2023 · 5 comments · Fixed by #583
Closed

Detector Parameters Update: Lepton Endcap HCal #573

Chao1009 opened this issue Oct 12, 2023 · 5 comments · Fixed by #583
Assignees
Labels
topic: backward Negative-rapidity detectors (electron-going side) topic: calorimetry

Comments

@Chao1009
Copy link
Contributor

A series of smaller issues from #552
det: new value from 2023/09/27 parameter table
sim: current simulation value as of 2023/10/11
template_var: from which we extract the sim value in compact files. Empty means we do not know.
stat: Correct, Missing, or Mismatched

Please implement the new detector parameters, and try to fill in the template_var for the Missing ones if you think it's important for future simulation/design comparison.

Here is the detailed report for this detector subsystem:

LEPTON DIRECTION ENDCAP, Backward HCal, : 
                           det  sim template_var     stat
Length (cm)               45.0  NaN        Empty  Missing
Inner Radius (cm)         12.4  NaN        Empty  Missing
Outer Radius (cm)        267.0  NaN        Empty  Missing
Offset from Center (cm) -395.0  NaN        Empty  Missing
Physical Start (cm)     -440.0  NaN        Empty  Missing
Physical End (cm)       -395.0  NaN        Empty  Missing
@lkosarz
Copy link
Contributor

lkosarz commented Oct 21, 2023

I made the updates, but we may need to verify if the inner part doesn't overlap with any of the beampipes

LEPTON DIRECTION ENDCAP, Backward HCal, :
det sim template_var stat
Length (cm) 45.0 45.0 45.0 Correct
Inner Radius (cm) 12.4 12.4 12.4 Correct
Outer Radius (cm) 267.0 267.0 267.0 Correct
Offset from Center (cm) -395.0 -395.0 -395.0 Correct
Physical Start (cm) -440.0 -440.0 -440.0 Correct
Physical End (cm) -395.0 -395.0 -395.0 Correct

@lkosarz
Copy link
Contributor

lkosarz commented Oct 21, 2023

There are overlaps, but the local coordinates don't tell me much, are they local to the beampipe?

2023-10-21T03:08:34.1340740Z           Overlap is detected for volume AV_10875!BeamPipe_assembly_26#26!v_upstream_matter_9#9:36 (G4SubtractionSolid) with AV_10874!HcalEndcapN_25#25!endcap_0#0:26 (G4Polyhedra)
2023-10-21T03:08:34.1342864Z           overlap at local point (-133.331,12.2908,-132.926) by 9.7918 mm  (max of 17 cases)
2023-10-21T03:08:34.1344217Z NOTE: Reached maximum fixed number -1- of overlaps reports for this volume !
2023-10-21T03:08:34.1345185Z *** This is just a warning message. ***
2023-10-21T03:08:34.1346044Z -------- WWWW -------- G4Exception-END --------- WWWW -------
2023-10-21T03:08:34.1346660Z 
2023-10-21T03:08:34.1386417Z 
2023-10-21T03:08:34.1387187Z -------- WWWW ------- G4Exception-START -------- WWWW -------
2023-10-21T03:08:34.1387932Z *** G4Exception : GeomVol1002
2023-10-21T03:08:34.1388565Z       issued by : G4PVPlacement::CheckOverlaps()
2023-10-21T03:08:34.1389203Z Overlap with volume already placed !
2023-10-21T03:08:34.1390579Z           Overlap is detected for volume AV_10875!BeamPipe_assembly_26#26!v_upstream_vacuum_10#10:37 (G4UnionSolid) with AV_10874!HcalEndcapN_25#25!endcap_0#0:26 (G4Polyhedra)
2023-10-21T03:08:34.1392332Z           overlap at local point (-132.272,8.16977,-141.989) by 8.51785 mm  (max of 43 cases)
2023-10-21T03:08:34.1393518Z NOTE: Reached maximum fixed number -1- of overlaps reports for this volume !

@lkosarz
Copy link
Contributor

lkosarz commented Nov 2, 2023

I can say that we have inner radius of 14cm implemented in our work in progress version. I will put that value in for now and communicate with Tanya.

@lkosarz
Copy link
Contributor

lkosarz commented Nov 2, 2023

Oh wait, which Tanya should I contact? Did you mean Tanja Horn?

@Chao1009
Copy link
Contributor Author

Chao1009 commented Nov 7, 2023

Yes, you can contact her through this page https://eic.jlab.org/Geometry/

github-merge-queue bot pushed a commit that referenced this issue Nov 21, 2023
Updated sizes with new values from 2023/09/27 parameter table

### Briefly, what does this PR introduce?


### What kind of change does this PR introduce?
- [x] Bug fix (issue #573)
- [ ] New feature (issue #__)
- [ ] Documentation update
- [ ] Other: __

### Please check if this PR fulfills the following:
- [ ] Tests for the changes have been added
- [ ] Documentation has been added / updated
- [ ] Changes have been communicated to collaborators

### Does this PR introduce breaking changes? What changes might users
need to make to their code?
Need to verify if it doesn't overlap with any beampipes

### Does this PR change default behavior?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: backward Negative-rapidity detectors (electron-going side) topic: calorimetry
Projects
Development

Successfully merging a pull request may close this issue.

2 participants