-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detector Parameters Update: Lepton Endcap HCal #573
Comments
I made the updates, but we may need to verify if the inner part doesn't overlap with any of the beampipes LEPTON DIRECTION ENDCAP, Backward HCal, : |
There are overlaps, but the local coordinates don't tell me much, are they local to the beampipe?
|
I can say that we have inner radius of 14cm implemented in our work in progress version. I will put that value in for now and communicate with Tanya. |
Oh wait, which Tanya should I contact? Did you mean Tanja Horn? |
Yes, you can contact her through this page https://eic.jlab.org/Geometry/ |
Updated sizes with new values from 2023/09/27 parameter table ### Briefly, what does this PR introduce? ### What kind of change does this PR introduce? - [x] Bug fix (issue #573) - [ ] New feature (issue #__) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [ ] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? Need to verify if it doesn't overlap with any beampipes ### Does this PR change default behavior?
A series of smaller issues from #552
det
: new value from 2023/09/27 parameter tablesim
: current simulation value as of 2023/10/11template_var
: from which we extract the sim value in compact files.Empty
means we do not know.stat
:Correct
,Missing
, orMismatched
Please implement the new detector parameters, and try to fill in the
template_var
for theMissing
ones if you think it's important for future simulation/design comparison.Here is the detailed report for this detector subsystem:
The text was updated successfully, but these errors were encountered: