Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mpgd disks parameter table update #593

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Conversation

mposik1983
Copy link
Contributor

Briefly, what does this PR introduce?

Updates MPGD disks to match detector parameter table

What kind of change does this PR introduce?

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • [ x] Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

There should be no breaking changes

Does this PR change default behavior?

No

@wdconinc
Copy link
Contributor

Looks good to me but deferring to @Chao1009

Copy link
Contributor

@Chao1009 Chao1009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Chao1009 Chao1009 added this pull request to the merge queue Nov 15, 2023
Merged via the queue into main with commit c49d3fe Nov 15, 2023
85 checks passed
@Chao1009 Chao1009 deleted the mpgd_disks_parameter_table_update branch November 15, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants