Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct warning message when using setup.sh #734

Merged
merged 1 commit into from
May 23, 2024
Merged

Conversation

wdconinc
Copy link
Contributor

Briefly, what does this PR introduce?

This PR fixes the warning which said:

Warning: This script will cease to exist at '/opt/detector/epic-main/setup.sh'.
         Please use the version at '/opt/detector/epic-main/thisepic.sh'.

to say the following instead:

Warning: This script will cease to exist at '/opt/detector/epic-main/setup.sh'.
         Please use the version at '/opt/detector/epic-main/bin/thisepic.sh'.

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No.

Does this PR change default behavior?

No.

@wdconinc wdconinc requested a review from veprbl May 23, 2024 18:51
@github-actions github-actions bot added the topic: infrastructure Regarding build system, CI, CD label May 23, 2024
@wdconinc wdconinc enabled auto-merge May 23, 2024 18:51
@veprbl veprbl added the backport 24.05 Backport into 24.05 label May 23, 2024
@wdconinc wdconinc added this pull request to the merge queue May 23, 2024
Merged via the queue into main with commit cd33003 May 23, 2024
109 checks passed
@wdconinc wdconinc deleted the fix-setup.sh branch May 23, 2024 23:54
@epic-capybara
Copy link

Successfully created backport PR for 24.05:

veprbl pushed a commit that referenced this pull request May 23, 2024
# Description
Backport of #734 to `24.05`.

Co-authored-by: Wouter Deconinck <wdconinc@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 24.05 Backport into 24.05 topic: infrastructure Regarding build system, CI, CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants