fix: ZDC_Crystal_Hits -> ZDCEcalHits, ZDC_PbScinti_Hits -> ZDCHcalHits #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wdconinc
changed the title
|
Force-merging to get benchmarks working again. None of the github workflows are going to be affected by this change. |
2 tasks
7 tasks
wdconinc
added a commit
that referenced
this pull request
Oct 3, 2022
…s (part 2) (#32) ### Briefly, what does this PR introduce? Addition to #30: also change readout field in detectors. ### What kind of change does this PR introduce? - [X] Bug fix (issue #__) - [ ] New feature (issue #__) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [ ] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? No. ### Does this PR change default behavior? No.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
#26 introduced new readout names, which translate into new hit collections that are used for reconstruction. This is now causing reconstructions to fail in many benchmarks (including full simulation production reconstruction) and causing analysis of these hit collections to fail due to the rename. So, we're just going to back out the name change.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
Yes. Back to ZDCEcalHits and ZDCHcalHits.