Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ZDC_Crystal_Hits -> ZDCEcalHits, ZDC_PbScinti_Hits -> ZDCHcalHits (part 2) #32

Merged
merged 5 commits into from
Oct 3, 2022

Conversation

wdconinc
Copy link
Contributor

@wdconinc wdconinc commented Oct 3, 2022

Briefly, what does this PR introduce?

Addition to #30: also change readout field in detectors.

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No.

Does this PR change default behavior?

No.

@wdconinc wdconinc changed the title Zdc readout names fix: ZDC_Crystal_Hits -> ZDCEcalHits, ZDC_PbScinti_Hits -> ZDCHcalHits (part 2) Oct 3, 2022
@wdconinc wdconinc merged commit 48f7281 into master Oct 3, 2022
@wdconinc wdconinc deleted the zdc-readout-names branch October 3, 2022 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant