Added beampipe envelope size at end of hadron endcap #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I merely added an extra size to the envelope of the outgoing hadron beampipe. I'm not sure if any other dimensions need to be added (like the incoming lepton beampipe size), or if this is fine. |
|
I personally don't have access to the beampipe CAD file. If someone familiar with the beampipe could double check that the envelope radius is 17.3 cm at z = 500 cm, that would be helpful. |
|
Ran checkOverlaps.py from epic repository and no overlaps detected. |
Added as issue #37 |
wdconinc
approved these changes
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
The expanding beampipe should extend to the hadron endcap to ensure no overlaps are introduced by future geometry development.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
None. Could create additional overlaps that weren't there previously, but so far have not seen any.
Does this PR change default behavior?
Yes, the beampipe is slightly longer and larger in the outgoing hadron direction.