Skip to content
This repository has been archived by the owner on Sep 4, 2024. It is now read-only.

Extend the beampipe to the end of the hadron endcap #33

Closed
rymilton opened this issue Oct 3, 2022 · 2 comments
Closed

Extend the beampipe to the end of the hadron endcap #33

rymilton opened this issue Oct 3, 2022 · 2 comments
Assignees

Comments

@rymilton
Copy link
Contributor

rymilton commented Oct 3, 2022

Is your feature request related to a problem? Please describe.
Currently, the beampipe only goes about halfway through the hadron endcap. This makes it difficult to correctly track overlaps with the beampipe throughout the entire hadron endcap.

Describe the solution you'd like
Add the dimension for the beampipe envelope at z = 500 cm.

Describe alternatives you've considered
N/A

Additional context
Important when developing detectors close to the beampipe!

@rymilton rymilton self-assigned this Oct 3, 2022
@rymilton
Copy link
Contributor Author

rymilton commented Oct 3, 2022

I was told (by person with beampipe CAD file) that the beampipe envelope radius is 17.3 cm at z = 500 cm, which is ~20 cm after the hadron endcap. This is the number I am using in my upcoming pull request.

wdconinc pushed a commit that referenced this issue Oct 3, 2022
### Briefly, what does this PR introduce?
The expanding beampipe should extend to the hadron endcap to ensure no
overlaps are introduced by future geometry development.

### What kind of change does this PR introduce?
- [ ] Bug fix (issue #__)
- [x] New feature (issue #33 )
- [ ] Documentation update
- [ ] Other: __

### Please check if this PR fulfills the following:
- [ ] Tests for the changes have been added
- [ ] Documentation has been added / updated
- [x] Changes have been communicated to collaborators

### Does this PR introduce breaking changes? What changes might users
need to make to their code?
None. Could create additional overlaps that weren't there previously,
but so far have not seen any.

### Does this PR change default behavior?
Yes, the beampipe is slightly longer and larger in the outgoing hadron
direction.
@rymilton
Copy link
Contributor Author

rymilton commented Oct 3, 2022

Fixed with pull request #34

@rymilton rymilton closed this as completed Oct 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant