Fix a problem where the RabbitMQPublisher could deadlock

[t-persson]

Applicable Issues

Description of the Change

There have been multiple problems with this code. One problem is that it would send events from two different threads. The main thread and the thread that resends nacked events. This could cause the RabbitMQ server to disconnect the client.
Secondly since the send_event method would block and wait for the client to reconnect in case of disconnects, the resend_nacked_events method could block the IOLoop which would prevent the client from reconnecting, thus causing a deadlock

Alternate Designs

I thought about having a queue of events instead which send_event and _resend_nacked_events would populate and having a separate thread go through this queue and send events.
This was a part of the previous design of this library and it had multiple problems due to the complexity that threading adds when using pika.

Benefits

Deadlocks are dangerous and we don't want to have to reconnect because we behave badly.

Possible Drawbacks

This adds more complexity and overhead.

Sign-off

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Signed-off-by: Tobias Persson tobias.persson@axis.com

[t-persson]

Must protect class attributes within send_event as well.

[t-persson]

Copyright notice needs an update of the year