Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a problem where the RabbitMQPublisher could deadlock #43

Merged
merged 4 commits into from
Jan 20, 2022

Commits on Jan 17, 2022

  1. Fix a problem where the RabbitMQPublisher could deadlock

    There have been multiple problems with this code.
    One problem is that it would send events from two different
    threads. The main thread and the thread that resends nacked
    events. This could cause the RabbitMQ server to disconnect
    the client.
    Secondly since the send_event method would block and wait
    for the client to reconnect in case of disconnects, the
    resend_nacked_events method could block the IOLoop which
    would prevent the client from reconnecting, thus causing
    a deadlock
    t-persson committed Jan 17, 2022
    Configuration menu
    Copy the full SHA
    c8d2ed2 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2022

  1. Configuration menu
    Copy the full SHA
    b37b770 View commit details
    Browse the repository at this point in the history
  2. Fix a bug with releasing a non-acquired lock

    Added a lot of debug information as well which will be active
    until we've verified this PR
    t-persson committed Jan 19, 2022
    Configuration menu
    Copy the full SHA
    936e2da View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2022

  1. Update copyright year

    t-persson committed Jan 20, 2022
    Configuration menu
    Copy the full SHA
    63a3ee6 View commit details
    Browse the repository at this point in the history