Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RemremGenerateController doesn't log exceptions in catch-all traps #140

Closed
magnusbaeck opened this issue Oct 28, 2019 · 0 comments
Closed

RemremGenerateController doesn't log exceptions in catch-all traps #140

magnusbaeck opened this issue Oct 28, 2019 · 0 comments

Comments

@magnusbaeck
Copy link
Member

Description

The handlers in RemremGenerateController each have catch (Exception e) { ... } blocks that translate unanticipated exceptions into 500 errors. That's fine, but nothing is logged so even those with access to the service logs can debug what's going wrong.

Motivation

Ideally we should never hit the catch-all exception handlers, but if we do it's important to save sufficient details about the error to make it possible for operators of the service to be able to debug the problem.
@magnusbaeck magnusbaeck mentioned this issue Oct 28, 2019
Closed
magnusbaeck added a commit to magnusbaeck/eiffel-remrem-generate that referenced this issue Oct 28, 2019
@magnusbaeck
Log exceptions in catch-all exception traps (fixes eiffel-community#140)
e62e488 
Unless we explicitly log the exceptions caught in our catch-all
blocks they'll never get logged and it'll be close to impossible
to debug them.
@magnusbaeck magnusbaeck mentioned this issue Oct 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@magnusbaeck