Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor issues found #145

Closed
Umadevi-Kapu opened this issue Jun 29, 2017 · 3 comments
Closed

Minor issues found #145

Umadevi-Kapu opened this issue Jun 29, 2017 · 3 comments

Comments

@Umadevi-Kapu
Copy link
Contributor

Found some minor issues while reading through the protocol.

EiffelActivityTriggeredEvent

  • Legal values for data.triggers.type are not mentioned in schema file.

EiffelTestCaseFinishedEvent

  • Mismatch of required fields.
  • data.outcome.metrics.name and data.outcome.metrics.value are required fields in schema file but are described as Not Mandatory in EiffelTestCaseFinishedEvent.md file.

EiffelTestCaseTriggeredEvent

  • Legal values for data.triggers.type is not mentioned in schema file.

EiffelTestCaseCanceledEvent

  • Simple Example link in EiffelTestCaseCanceledEvent.md is not working.

EiffelTestExecutionRecipeCollectionCreatedEvent

  • data.batches.recipes.constraints field mentioned as required in schema is mentioned as not required in EiffelTestExecutionRecipeCollectionCreatedEvent.md
  • 2nd line of 5th paragraph in EiffelTestExecutionRecipeCollectionCreatedEvent.md says that "The EiffelTestExecutionRecipeCollectionCreatedEvent does control the syntax of these constraints" but it should be "does not control the syntax" as per data.batches.recipes.constraints description.
Umadevi-Kapu added a commit to Umadevi-Kapu/eiffel that referenced this issue Jun 29, 2017
@Umadevi-Kapu
Issue eiffel-community#145, Minor issues fixed
a079b4c
@d-stahl-ericsson
Copy link
Contributor

Great! Thanks for finding these :)

Umadevi-Kapu added a commit to Umadevi-Kapu/eiffel that referenced this issue Jun 30, 2017
@Umadevi-Kapu
Issue eiffel-community#145, Minor issues fixed
4d07f8c
@Umadevi-Kapu
Copy link
Contributor Author

Found one more issue in EiffelTestCaseTriggeredEvent
*Missed "type": "object" in "parameters" field in schema file.

d-stahl-ericsson pushed a commit that referenced this issue Jul 4, 2017
@Umadevi-Kapu @d-stahl-ericsson
Minor issues fixed (#146)
0a2f9ef 
Minor bugs listed in issue #145 fixed:
* Several cases of mismatching event documentation and schemas
* EiffelTestCaseFinishedEvent stepped to 1.0.1 due to two properties being made mandatory
* Typos fixed
@d-stahl-ericsson
Copy link
Contributor

PR merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@d-stahl-ericsson @Umadevi-Kapu