Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for verifying that each event definition file has a history table entry #351

Closed
magnusbaeck opened this issue May 19, 2023 · 0 comments · Fixed by #352
Closed
Assignees

Comments

@magnusbaeck
Copy link
Member

Description

We should add a test (pytest-based, preferably) that verifies that each definitions/Eiffel*Event/x.y.z.yml has an object in its _history array with the version key set to x.y.z.

Motivation

Two recent PRs (#322 and #350) have added new versions of events without adding the required entry in the history table. That should've been caught by a test.

Exemplification

See aforementioned PRs.

Benefits

Less burden on reviewers, quicker review times, and decreased risk of errors sneaking in.

Possible Drawbacks

None.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant