New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue 317 - add SCS and SCC as legal target for IUT in TCT #350
Fix issue 317 - add SCS and SCC as legal target for IUT in TCT #350
Conversation
Co-authored-by: Tobias Persson <tobiaspn@axis.com>
Also, I'd kinda expected new target link types to be a minor version bump rather than a patch bump. That's what's proposed in the ArtD PR (#322) where a number of event types can start linking to ArtD. |
@@ -251,6 +251,7 @@ __Description:__ A URI pointing at a location from where the schema used when cr | |||
|
|||
| Version | Introduced in | Changes | | |||
| ------- | ------------- | ------- | | |||
| 3.3.0 | Current version | Add SCS and SCC as legal target for IUT in TCT (see [Issue 317](https://github.com/eiffel-community/eiffel/issues/317)). | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have any good idea what to write for "Introduced in"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The big table on https://github.com/eiffel-community/eiffel/blob/master/eiffel-syntax-and-usage/event-schemas.md specifies that "No edition set" should be used. That's nonsense, hence #326.
@magnusbaeck True, fixed that in 0b46231 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The history table doesn't say exactly what it's supposed to say, but that'll become irrelevant once we release Orizaba so feel free to merge anyway.
Applicable Issues
Fixes #317
Description of the Change
This PR fixes the inconsistency by allowing TCT to use the same link target as CLM. Before it was like this :
CLM allows to SUBJECT link to CD, ArtC, as well as SCC and SCS
TCT link Item Under Test (IUT) only allows CD or ArtC as targets, enforcing an extra CD with ELEMENT link to use SCC as IUT when running tests on source code.
Alternate Designs
None
Benefits
Confusing why you can set a confidence level on for example a SCS event but you can't use the same event as a IUT link
Possible Drawbacks
None that I can think of
Sign-off
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
Signed-off-by: Mattias Linnér mattias.linner@ericsson.com