Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated versioning information in preparation of edition-bordeaux #139

Conversation

d-stahl-ericsson
Copy link
Contributor

Version tables in versioning.md and in individual event type definitions was updated for edition-bordeaux. Also added a Changes column to the version tables, to allow description of changes from version to version, both on a protocol edition level and on an individual event level.

Editions list populated with additional names reserved for future use.
The Bordeaux edition updated with link to actual release tag.
@xvinosi-github
Copy link
Contributor

The documentation of each event type lists the complete version history of that type, including links to commits introducing older versions of the type.
Should linking commits be removed in above line in version.md file since we changed it

@d-stahl-ericsson
Copy link
Contributor Author

Not sure I follow. Did we change it? The version table in the event type documentation still links to introducing commits. The initial version linking to the Bordeaux edition is just a special case, because we pretend that all events were defined in their current 1.0.0 syntax, with no history.

When 1.1.0 of event type X comes around, the table will read:

Version History

Version Introduced in Changes
1.1.0 Current version Lots of great improvements.
1.0.0 edition-bordeaux Initial version.

And then 1.2.0 is added:

Version History

Version Introduced in Changes
1.2.0 Current version Turned everything on its head.
1.1.0 be76d82fc4db433aac79ad015d87d7dfcec72ae0 Lots of great improvements.
1.0.0 edition-bordeaux Initial version.

So I think the statement in versioning.md is still true?

@erobged
Copy link

erobged commented Apr 12, 2017

All events seem to have been updated with version info as discussed in Change:"Updated individual event type version tables."
looks good to go.

@erobged
Copy link

erobged commented Apr 12, 2017

Re: Change "Added Changes column to editions table".
It looks good to me.

@xvinosi-github
Copy link
Contributor

Agree! Was assuming only Edition information would be present in Version History.
Everything Looks OK.

@e-backmark-ericsson
Copy link
Member

👍

@d-stahl-ericsson d-stahl-ericsson merged commit 11a801d into eiffel-community:master Apr 12, 2017
@d-stahl-ericsson d-stahl-ericsson deleted the release-edition-bordeaux branch September 13, 2018 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants