Added Notes on Custom Events #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| * Custom events are not allowed masquerade as standard Eiffel events, and shall therefore not be prefixed "Eiffel". To exemplify, a recommended custom event name would be "MyCustomEvent", but not "EiffelMyCustomEvent". | ||
| * Use [Issues](https://github.com/Ericsson/eiffel/issues) and [Pull requests](https://github.com/Ericsson/eiffel/pulls) to stay in touch with the community to discuss why and how you define custom events. Others may find them useful, too! | ||
| * Follow the [event design guidelines](./event-design-guidelines.md). |
There was a problem hiding this comment.
Should we also add a "Follow the principles in introduction regarding technology Agnostic, Tracability, scalability flexibility". This is to some degree described in event design guidelines but gives a lot more information.
There was a problem hiding this comment.
Better to be more explicit about it in the event design guidelines, in that case.
There was a problem hiding this comment.
Pushed to the Event Guidelines PR. #24
|
We have no ability to check or enforce this. |
|
This should be under a separate Customization heading in README. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.