validate.py: Replace deprecated time.clock() calls #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
time.clock() is deprecated and removed in Python 3.8. It was replaced by time.process_time() and time.perf_counter() in Python 3.3. Replace the calls in examples/validate.py with time.perf_counter(). This drops support for Python 2 so the shebang is adjusted (not that the shebang is very useful for this non-executable file). This also fixes what probably was an unintentional buglet; on Linux time.clock() returned the elapsed CPU time but on Windows it returned the elapsed time. Since the number was seemingly used to report the validation progress every five seconds the behavior was only correct on Windows.
k-hallen-ericsson
approved these changes
Dec 14, 2020
t-persson
approved these changes
Dec 14, 2020
e-backmark-ericsson
approved these changes
Dec 14, 2020
e-backmark-ericsson
pushed a commit
to e-backmark-ericsson/eiffel
that referenced
this pull request
Apr 13, 2022
) time.clock() is deprecated and removed in Python 3.8. It was replaced by time.process_time() and time.perf_counter() in Python 3.3. Replace the calls in examples/validate.py with time.perf_counter(). This drops support for Python 2 so the shebang is adjusted (not that the shebang is very useful for this non-executable file). This also fixes what probably was an unintentional buglet; on Linux time.clock() returned the elapsed CPU time but on Windows it returned the elapsed time. Since the number was seemingly used to report the validation progress every five seconds the behavior was only correct on Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applicable Issues
Fixes #250
Description of the Change
time.clock() is deprecated and removed in Python 3.8. It was replaced by time.process_time() and time.perf_counter() in Python 3.3. Replace the calls in examples/validate.py with time.perf_counter(). This drops support for Python 2 so the shebang is adjusted (not that the shebang is very useful for this non-executable file).
This also fixes what probably was an unintentional buglet; on Linux time.clock() returned the elapsed CPU time but on Windows it returned the elapsed time. Since the number was seemingly used to report the validation progress every five seconds the behavior was only correct on Windows.
Alternate Designs
We could've used time.time() given the low resolution requirement and the fact that we don't really care that that call returns a non-monotonous clock. That would've kept Python 2 compatibility, but Python 2 was EOLed almost a year ago so it's reasonable to drop support for it.
Benefits
The script will work with Python 3.8.
Possible Drawbacks
The script won't work with Python 2.x.
Sign-off
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or
(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or
(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.
(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.
Signed-off-by: Magnus Bäck <magnus.back@axis.com>