Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change definition of "introduced_in" field in the history tables #354

Merged
merged 2 commits into from Jun 29, 2023

Conversation

magnusbaeck
Copy link
Member

Applicable Issues

Fixes #326
Fixes #327

Description of the Change

The introduced_in field in entries of the history tables has previously only had a well-defined and obvious meaning for event versions that were the latest version in a released edition. To make the files more consistent and easier to maintain we change the field to be the Git tag where the event version was first introduced, or null if the version hasn't been released yet. This also makes the field machine-readable, and we'll render it to a clickable link in the Markdown to the documentation generator.

Alternate Designs

None.

Benefits

Easier to understand and maintain the documentation.

Possible Drawbacks

In some cases the version history tables referenced commit SHA-1s. This change replaces this with edition references which is less granular. Of course, if you want to know exactly which commit introduced the version that is easily available from the git.

Sign-off

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.

Signed-off-by: Magnus Bäck <magnus.back@axis.com>

That field has previously only had a well-defined and obvious meaning
for event versions that were the latest version in a released edition.
To make the files more consistent and easier to maintain we change the
field to be the Git tag where the event version was first introduced,
or null if the version hasn't been released yet. This also makes the
field machine-readable, and we'll render it to a clickable link in the
Markdown to the documentation generator.
@magnusbaeck magnusbaeck requested a review from a team as a code owner June 24, 2023 22:10
t-persson
t-persson previously approved these changes Jun 26, 2023
Copy link
Member

@m-linner-ericsson m-linner-ericsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things:

  • Change needed: Noticed that the copyright headers needs update on all the files if we change them.
  • Comment: If one tries to regenerate the Markdown files in an older edition using the YAML files, the result will differ from previous generated markdown (e.g. if you look at a older version via a tag)

@magnusbaeck
Copy link
Member Author

If one tries to regenerate the Markdown files in an older edition using the YAML files, the result will differ from previous generated markdown (e.g. if you look at a older version via a tag)

Sure. That'll happen every time the documentation generator changes. That's fine since we keep all versions in separate files and therefore are able to generate documentation for any event.

@magnusbaeck magnusbaeck merged commit 2caec32 into eiffel-community:master Jun 29, 2023
2 checks passed
@magnusbaeck magnusbaeck deleted the introduced_in branch June 29, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants